Adding serviceAccountAuthConfig to google_dialogflow_cx_webhook; #16083

zhihaos · 2026-01-06T21:34:27Z

dialogflowcx: added `serviceAccountAuthConfig ` field to `google_dialogflow_cx_webhook` resource

modular-magician · 2026-01-06T21:48:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 180 insertions(+))
google-beta provider: Diff ( 3 files changed, 180 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 66 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_cx_webhook (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_cx_webhook" "primary" {
  generic_web_service {
    service_account_auth_config {
      service_account = # value needed
    }
  }
  service_directory {
    generic_web_service {
      service_account_auth_config {
        service_account = # value needed
      }
    }
  }
}

modular-magician · 2026-01-06T21:54:53Z

Tests analytics

Total tests: 46
Passed tests: 44
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-06T21:55:20Z

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-01-07T17:05:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 276 insertions(+))
google-beta provider: Diff ( 4 files changed, 276 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 66 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_cx_webhook (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_cx_webhook" "primary" {
  service_directory {
    generic_web_service {
      service_account_auth_config {
        service_account = # value needed
      }
    }
  }
}

modular-magician · 2026-01-07T17:15:02Z

Tests analytics

Total tests: 47
Passed tests: 44
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-07T17:15:50Z

🟢 Tests passed during RECORDING mode:
TestAccDialogflowCXWebhook_dialogflowcxWebhookServiceAccountAuthExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-01-07T17:39:47Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 364 insertions(+))
google-beta provider: Diff ( 4 files changed, 364 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 66 insertions(+))

modular-magician · 2026-01-07T17:44:55Z

Tests analytics

Total tests: 48
Passed tests: 44
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-07T17:45:44Z

🟢 Tests passed during RECORDING mode:
TestAccDialogflowCXWebhook_dialogflowcxWebhookWithServiceAccountAuthExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]
TestAccDialogflowCXWebhook_dialogflowcxWebhookServiceDirectoryWithServiceAccountAuthExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-01-07T18:21:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 366 insertions(+))
google-beta provider: Diff ( 4 files changed, 366 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 66 insertions(+))

modular-magician · 2026-01-07T18:29:04Z

Tests analytics

Total tests: 48
Passed tests: 45
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-07T18:29:34Z

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]
TestAccDialogflowCXWebhook_dialogflowcxWebhookServiceDirectoryWithServiceAccountAuthExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-01-07T18:53:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 366 insertions(+))
google-beta provider: Diff ( 4 files changed, 366 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 66 insertions(+))

modular-magician · 2026-01-07T18:59:05Z

Tests analytics

Total tests: 48
Passed tests: 45
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-07T18:59:54Z

🟢 Tests passed during RECORDING mode:
TestAccDialogflowCXWebhook_dialogflowcxWebhookServiceDirectoryWithServiceAccountAuthExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2026-01-07T19:49:10Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions · 2026-01-12T09:49:31Z

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

zhihaos · 2026-01-13T21:17:03Z

@c2thorn, hi Cameron, this is a customer escalation, do you have time to review it? Thanks!

github-actions · 2026-01-14T09:47:37Z

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

c2thorn · 2026-01-14T21:31:43Z

/gcbrun

c2thorn · 2026-01-14T21:32:18Z

checking VCR recording results, we are trying to be more strict with merging failing tests. PR LGTM, just waiting on VCR confirmation.

modular-magician · 2026-01-14T21:44:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 366 insertions(+))
google-beta provider: Diff ( 4 files changed, 366 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 66 insertions(+))

modular-magician · 2026-01-14T21:52:40Z

Tests analytics

Total tests: 48
Passed tests: 46
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

c2thorn

test rerun passed. LGTM

Adding new fields;

9bb2f16

modular-magician added the service/dialogflow-cx label Jan 6, 2026

Add an example;

c4b78a2

Adding more examples;

7b49fc2

add the missing service field;

abfc677

fix the example;

4cd9614

zhihaos marked this pull request as ready for review January 7, 2026 19:47

github-actions bot requested a review from c2thorn January 7, 2026 19:49

c2thorn approved these changes Jan 14, 2026

View reviewed changes

c2thorn added this pull request to the merge queue Jan 14, 2026

Merged via the queue into GoogleCloudPlatform:main with commit 3e5b319 Jan 14, 2026
27 checks passed

Adding serviceAccountAuthConfig to google_dialogflow_cx_webhook; #16083

Adding serviceAccountAuthConfig to google_dialogflow_cx_webhook; #16083

Conversation

zhihaos commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Jan 6, 2026

Diff report

Missing test report

Uh oh!

modular-magician commented Jan 6, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 6, 2026

Uh oh!

modular-magician commented Jan 7, 2026

Diff report

Missing test report

Uh oh!

modular-magician commented Jan 7, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 7, 2026

Uh oh!

modular-magician commented Jan 7, 2026

Diff report

Uh oh!

modular-magician commented Jan 7, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 7, 2026

Uh oh!

modular-magician commented Jan 7, 2026

Diff report

Uh oh!

modular-magician commented Jan 7, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 7, 2026

Uh oh!

modular-magician commented Jan 7, 2026

Diff report

Uh oh!

modular-magician commented Jan 7, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

zhihaos commented Jan 13, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

c2thorn commented Jan 14, 2026

Uh oh!

c2thorn commented Jan 14, 2026

Uh oh!

modular-magician commented Jan 14, 2026

Diff report

Uh oh!

modular-magician commented Jan 14, 2026

Tests analytics

Uh oh!

c2thorn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

zhihaos commented Jan 6, 2026 •

edited

Loading